ANDROID-14825 Add fonts in Mistica Catalog app #394
Conversation
|
📱 New catalog for testing generated: Download |
| ComponentStyle("O2", R.style.CatalogO2, O2), | ||
| ComponentStyle("Vivo", R.style.CatalogVivo, VIVO), | ||
| ComponentStyle("Vivo New", R.style.CatalogVivoNew, VIVO_NEW), | ||
| ComponentStyle("Telefonica", R.style.CatalogTelefonica, TELEFONICA), | ||
| ComponentStyle("Blau", R.style.MisticaTheme_Blau, BLAU), |
There was a problem hiding this comment.
Blau has a licensed font
There was a problem hiding this comment.
Even if we dont have that font in our catalog could we have a CatalogBlau like the rest of the brands, even if is empty?
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
| override val compatibilityTheme: Int | ||
| get() = R.style.MisticaTheme_Movistar |
There was a problem hiding this comment.
this should be CatalogMovistar so AndroidViews still use the correct font. Same for other brands
| import com.telefonica.mistica.compose.theme.color.MisticaColors | ||
| import com.telefonica.mistica.compose.theme.values.MisticaRadius | ||
|
|
||
| object CatalogMovistarBrand : Brand { |
There was a problem hiding this comment.
we can create a CatalogBrand and reuse it so we don't have to write all this code for every brand:
abstract class CatalogBrand(
private val basebBrand: Brand,
val theme: Int,
) : Brand {
override val compatibilityTheme: Int = theme
override val lightColors: MisticaColors = brand.lightColors
// ...
}The you can use it as follows:
object CatalogMovistarBrand : CatalogBrand(MovistarBrand, R.style.CatalogMovistar) {
override val fontFamily: FontFamily
get() = FontFamily(
Font(R.font.onair_light, FontWeight.Light),
Font(R.font.onair_regular, FontWeight.Normal),
Font(R.font.onair_medium, FontWeight.Medium),
)
}
|
📱 New catalog for testing generated: Download |
| ) | ||
| } | ||
|
|
||
| object CatalogO2Brand : CatalogBrand(O2Brand, R.style.CatalogO2) { |
There was a problem hiding this comment.
A minor, could we have O2 with his brother O2New together as Vivo is with its two themes?
Also, check XML too.
| val theme: Int, | ||
| ) : Brand { | ||
| override val compatibilityTheme: Int | ||
| get() = theme |
There was a problem hiding this comment.
Now seeing this, it is necessary that theme is computed every time that compatibilityTheme is retrieved? cc: @yamal-alm
There was a problem hiding this comment.
yes, we can use override val compatibilityTheme: Int = theme instead
|
📱 New catalog for testing generated: Download |
🥅 What's the goal?
Add fonts in Mistica Catalog app
🚧 How do we do it?
Added font archives and created correspondent themes for xml and Brand objects for Compose
☑️ Checks
🧪 How can I test this?