Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Image srcset prop in PosterCard #1138

Closed
walter-restifo-syzygy opened this issue Jun 4, 2024 · 1 comment
Closed

Support Image srcset prop in PosterCard #1138

walter-restifo-syzygy opened this issue Jun 4, 2024 · 1 comment

Comments

@walter-restifo-syzygy
Copy link

Hi guys,

I'm a developer of SYZYGY Techsolution working for O2.
In #1109 you have added the srcset attribute to the Image component. It would be nice, if you can implement the srcset in the Image of the PosterCard component, so that we can use responsive images in this component too.

This is the code
@marcoskolodny marcoskolodny mentioned this issue Sep 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 26, 2024
@marcoskolodny
feat(PosterCard, DisplayMediaCard): allow using srcSet for background…
3b3d85f 
…Image (#1253)

Motivation: #1138

Issue: [Link](https://jira.tid.es/browse/WEB-2048)
@marcoskolodny
Copy link
Collaborator

This has been developed in #1253

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoskolodny @walter-restifo-syzygy