Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Popover, Snackbar, Callout, Chip, Dialog, Cards): allow customizable close button label #1193

Merged
merged 3 commits into from
Aug 9, 2024
Merged

feat(Popover, Snackbar, Callout, Chip, Dialog, Cards): allow customizable close button label #1193

merged 3 commits into from
Aug 9, 2024

Conversation

marcoskolodny
Copy link
Collaborator

Issue: Link

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

Size stats

master this branch diff
Total JS 12.1 MB 12.1 MB +1.03 kB
JS without icons 2.02 MB 2.03 MB +1.03 kB
Lib overhead 76.7 kB 76.7 kB 0 B
Lib overhead (gzip) 18.7 kB 18.7 kB 0 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-4met65690-flows-projects-65bb050e.vercel.app

Built with commit 8753d4c.
This pull request is being automatically deployed with vercel-action

@aweell

This comment has been minimized.

Sign in to view
@marcoskolodny
Copy link
Collaborator Author

Can we add this to cards since they have an onClose and it's not possible to change that label?

Specs are updated accordingly

I've seen that the same text modalClose is being used in sheet, guess is for desktop since is equal to a dialog?

@aweell I've updated all the cards. About the sheet: yes, it's because of desktop mode. But I'm not sure adding the prop only because of this makes sense, given that sheet is commonly used in mobile devices

@marcoskolodny marcoskolodny changed the title feat(Popover, Snackbar, Callout, Chip, Dialog): allow customizable close button label feat(Popover, Snackbar, Callout, Chip, Dialog, Cards): allow customizable close button label Aug 6, 2024
aweell
aweell approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@aweell aweell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

atabel
atabel reviewed Aug 8, 2024
View reviewed changes
src/callout.tsx Outdated Show resolved Hide resolved
@marcoskolodny marcoskolodny added this pull request to the merge queue Aug 9, 2024
Merged via the queue into master with commit 63de33a Aug 9, 2024
11 checks passed
@marcoskolodny marcoskolodny deleted the WEB-1966-close-button-accessibility-label branch August 9, 2024 11:31
tuentisre pushed a commit that referenced this pull request Aug 20, 2024
@semantic-release-bot
chore(release): 15.18.0 [skip ci]
447a677 
# [15.18.0](v15.17.0...v15.18.0) (2024-08-20)

### Bug Fixes

* **FeedbackScreen:** avoid double responsive margins in buttons when they are not fixed ([#1195](#1195)) ([41c10ad](41c10ad))
* **Inline:** wrap content if required when space equals between/around/evenly ([#1199](#1199)) ([b121227](b121227))
* **Snackbar:** allow dataAttributes passed to openSnackbar ([#1192](#1192)) ([c5c65bd](c5c65bd))

### Features

* **Popover, Snackbar, Callout, Chip, Dialog, Cards:** allow customizable close button label ([#1193](#1193)) ([63de33a](63de33a))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 15.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atabel atabel atabel approved these changes

@aweell aweell aweell approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoskolodny @aweell @tuentisre @atabel