feat(Logo): Refactor logo to improve bundle size and loading times #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit aaecb03. |
|
Screenshot tests report ✔️ All passing |
pladaria
commented
Aug 23, 2024
| @@ -15,6 +15,7 @@ const NavigationBarTest = (): JSX.Element => ( | |||
| title, | |||
| to: `/${title}`, | |||
| }))} | |||
| logo={<span>LOGO</span>} | |||
There was a problem hiding this comment.
SSR tests fail with Lazy components.
Ticket to review this: https://jira.tid.es/browse/WEB-1998
pladaria
commented
Aug 23, 2024
| @@ -0,0 +1,61 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
each logo has its own file with a default export (this is required for lazy imports)
atabel
approved these changes
Aug 23, 2024
marcoskolodny
approved these changes
Aug 23, 2024
tuentisre
pushed a commit
that referenced
this pull request
Sep 3, 2024
# [15.19.0](v15.18.0...v15.19.0) (2024-09-03) ### Bug Fixes * **Buttons:** avoid warnings related to change in order of react hooks ([#1229](#1229)) ([2dbc411](2dbc411)) * **i18n): Revert "feat(i18n:** improve texts sizes" because it is breaking ([#1226](#1226)) ([79eb4a4](79eb4a4)) * **Logo:** fix webpackChunkName magic comments ([#1214](#1214)) ([3d1f098](3d1f098)) * **Vivinho char:** vivinho char in headings being read as a separated heading ([#1209](#1209)) ([f0f5fb0](f0f5fb0)) ### Features * **Buttons:** refactor code and fix spacing bug in loading buttonLink ([#1212](#1212)) ([640e429](640e429)) * **i18n:** improve texts sizes ([#1204](#1204)) ([0345e7c](0345e7c)) * **Logo:** Refactor logo to improve bundle size and loading times ([#1210](#1210)) ([15b77cb](15b77cb)) * **NavigationBar, FunnelNavigationBar, MainNavigationBar:** add alternative variant ([#1200](#1200)) ([eef87ec](eef87ec))
|
🎉 This PR is included in version 15.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-1986
modules of
page-example-feedbackbefore
after
No
logochunk in the bundle