Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Screen Mode #555

Merged
merged 39 commits into from
Nov 30, 2024
Merged

Conversation

theqeeqez
Copy link
Contributor

Telegram Bots API V8: Full Screen Mode

full-screen

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: fa78734

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@telegram-apps/sdk Minor
@telegram-apps/bridge Minor
@telegram-apps/types Minor
@telegram-apps/transformers Minor
@telegram-apps/sdk-react Patch
@telegram-apps/sdk-solid Patch
@telegram-apps/sdk-svelte Patch
@telegram-apps/sdk-vue Patch
@telegram-apps/navigation Patch
@telegram-apps/init-data-node Patch
svelte-template Patch
vue-template Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 10:49pm

@singerxt
Copy link

I can't wait for it! Thanks for doing it

@singerxt
Copy link

Would it be applicable to expose safe area values? The official telegram SDK set has CSS variables that I can use; however, I think it might be helpful to expose them via SDK, too.

I'm happy to create PR for your branch if you are open to it. Let me know

@theqeeqez
Copy link
Contributor Author

@singerxt this one is PR only for FullScreen mode from V8.
Let me push new PR for SafeArea where you could check if CSS vars is working 🙂

Copy link
Member

@heyqbnk heyqbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a lot of request changes and we can discuss them.

In case, you don't really have a lot of time to make them or much motivation, let me know. You did a great job and I will merge this Pull Request as-is without releasing an update, so you will be mentioned as a contributor in the repository.

I have a resource to make these changes by myself.

It seems like I also have to add some code style-related eslint configurations, so we would use a single one

packages/bridge/src/events/types/events.ts Outdated Show resolved Hide resolved
packages/bridge/src/events/types/events.ts Outdated Show resolved Hide resolved
apps/docs/platform/events.md Outdated Show resolved Hide resolved
apps/docs/platform/events.md Outdated Show resolved Hide resolved
packages/sdk/test-utils/reset/reset.ts Show resolved Hide resolved
@heyqbnk
Copy link
Member

heyqbnk commented Nov 24, 2024

I've read your comments, thank you for contribution!

We talked to Maksim in private and decided to transfer this Pull Request to me to complete requested changes and accomplish the Pull Request. To be done this week

@bucurdavid
Copy link

What is the release ETA for this ?
cc: @heyqbnk

… launch parameters and their transformers.
… resize as it is currently supported by the most of Telegram applications.

Implement `fullscreen_changed`, `fullscreen_failed`, `web_app_request_fullscreen` and `web_app_exit_fullscreen` events and methods.
@heyqbnk heyqbnk merged commit bf85d95 into Telegram-Mini-Apps:master Nov 30, 2024
2 checks passed
@theqeeqez theqeeqez deleted the botapi-8-fullscreen branch November 30, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants