-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Screen Mode #555
Full Screen Mode #555
Conversation
🦋 Changeset detectedLatest commit: fa78734 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I can't wait for it! Thanks for doing it |
Would it be applicable to expose safe area values? The official telegram SDK set has CSS variables that I can use; however, I think it might be helpful to expose them via SDK, too. I'm happy to create PR for your branch if you are open to it. Let me know |
@singerxt this one is PR only for FullScreen mode from V8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a lot of request changes and we can discuss them.
In case, you don't really have a lot of time to make them or much motivation, let me know. You did a great job and I will merge this Pull Request as-is without releasing an update, so you will be mentioned as a contributor in the repository.
I have a resource to make these changes by myself.
It seems like I also have to add some code style-related eslint configurations, so we would use a single one
I've read your comments, thank you for contribution! We talked to Maksim in private and decided to transfer this Pull Request to me to complete requested changes and accomplish the Pull Request. To be done this week |
3eeeba7
to
ade63d8
Compare
… UnionOptionalKeys
What is the release ETA for this ? |
… launch parameters and their transformers.
… resize as it is currently supported by the most of Telegram applications. Implement `fullscreen_changed`, `fullscreen_failed`, `web_app_request_fullscreen` and `web_app_exit_fullscreen` events and methods.
Telegram Bots API V8: Full Screen Mode