Allow SerializerStates and Writers to own their SerializerConfigs
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes them easier to manage (no need for self-referencing) when they are seldom instantiated but need to be moved around/stored...
|
The reason I haven't merged this yet is that it shows regressions in the benchmarks and at this point I'm still unsure whether that's just noise. |
|
Ok so I've run more benchmarks so I'm convinced now that this is absolutely just noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14
This makes them easier to manage (no need for self-referencing) when they are seldom instantiated but need to be moved around/stored...