fix(core): LoadUntrustedContent crash protect

Tencent · Oct 17, 2024 · ad58331 · ad58331
1 parent 4fb3980
commit ad58331
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/driver/js/src/modules/contextify_module.cc b/driver/js/src/modules/contextify_module.cc
@@ -100,8 +100,14 @@ void ContextifyModule::LoadUntrustedContent(CallbackInfo& info, void* data) {
   auto scope_wrapper = reinterpret_cast<ScopeWrapper*>(std::any_cast<void*>(info.GetSlot()));
   auto scope = scope_wrapper->scope.lock();
   FOOTSTONE_CHECK(scope);
+  if (!scope) {
+    return;
+  }
   auto context = scope->GetContext();
   FOOTSTONE_CHECK(context);
+  if (!context) {
+    return;
+  }
   string_view uri;
   if (!context->GetValueString(info[0], &uri)) {
     info.GetExceptionValue()->Set(context, "The first argument must be non-empty string.");
@@ -207,6 +213,9 @@ void ContextifyModule::LoadUntrustedContent(CallbackInfo& info, void* data) {
 
   auto loader = scope->GetUriLoader().lock();
   FOOTSTONE_CHECK(loader);
+  if (!loader) {
+    return;
+  }
   loader->RequestUntrustedContent(uri, {}, cb);
 
   info.GetReturnValue()->SetUndefined();