Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devtools): fix the mapping between DOM tree and UI inspector #4122

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix(devtools): fix the mapping between DOM tree and UI inspector #4122

merged 4 commits into from
Nov 15, 2024

Conversation

Cyunong
Copy link
Contributor

@Cyunong Cyunong commented Nov 12, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added renderer: native devtools: backend size: m Denotes a PR that changes 100-499 lines labels Nov 12, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 12, 2024

Hi, @Cyunong. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 12, 2024

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@Cyunong Cyunong requested a review from wwwcg November 12, 2024 14:04
@Cyunong Cyunong requested a review from wwwcg November 13, 2024 03:29
wwwcg
wwwcg previously approved these changes Nov 14, 2024
View reviewed changes
siguangli
siguangli previously approved these changes Nov 15, 2024
View reviewed changes
@wwwcg wwwcg requested a review from zealotchen0 November 15, 2024 12:17
@Cyunong Cyunong dismissed stale reviews from siguangli and wwwcg via f69d299 November 15, 2024 13:27
@Cyunong Cyunong requested a review from zealotchen0 November 15, 2024 13:28
@zealotchen0 zealotchen0 merged commit e8c13d3 into Tencent:main Nov 15, 2024
7 of 8 checks passed
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Dec 11, 2024
@Cyunong @wwwcg
fix(devtools): fix the mapping between DOM tree and UI inspector (Ten…
40232f7 
…cent#4122)

* fix(devtools): fix the mapping between DOM tree and UI inspector

* fix(devtools): fix potential crash

* fix(devtools): fix magic number

* fix(devtools): fix the name of function
wwwcg pushed a commit that referenced this pull request Dec 11, 2024
@Cyunong @wwwcg
fix(devtools): fix the mapping between DOM tree and UI inspector (#4122)
719008e 
* fix(devtools): fix the mapping between DOM tree and UI inspector

* fix(devtools): fix potential crash

* fix(devtools): fix magic number

* fix(devtools): fix the name of function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

@siguangli siguangli siguangli left review comments

@wwwcg wwwcg wwwcg left review comments

@lavnFan lavnFan Awaiting requested review from lavnFan lavnFan is a code owner

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

@iPel iPel Awaiting requested review from iPel iPel is a code owner

Assignees
No one assigned
Labels
devtools: backend renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cyunong @tencent-adm @wwwcg @siguangli @zealotchen0