feat: Also expose C++ set
, getBytes
, getVector
methods
#1260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also exposes these methods to Apple Platforms:
Previously, those methods were hidden under a
#ifdef APPLE
/#else
branch, so that on Apple you could only use theNSObject<NSCoding>
classes.In my C++ environment (where I already had strings), it was a redundant extra step to convert from
std::string
<>NSString
, and fromMMBuffer
<>NSData
, so this PR removes that intermediate conversion step.Unfortunately I couldn't do the same thing for
allKeys
, as only the return type changes (NSArray*
vsstd::vector<std::string>
), so it cannot be overloaded.We could introduce an additional method that is available whether MMKV_APPLE is true or not, but that's up to you if you want to do that @lingol.