fix eslint #378

ljiawliu · 2021-09-18T08:04:53Z

No description provided.

--task=20210826

--task=20210827

--story=20210826

packages/feflow-cli/__tests__/core/logger/index.test.ts

xqxian · 2021-09-18T09:00:27Z

packages/feflow-cli/src/core/commander/index.ts

@@ -31,12 +31,12 @@ export default class Commander {
    if (Object.prototype.toString.call(name) !== '[object String]') {
      return;
    }
-    name = name.toLowerCase();
-    const invisibleCommand = this.invisibleStore[name];
+    const newName = name.toLowerCase();


叫 finalName 比较好

xqxian · 2021-09-18T09:06:10Z

packages/feflow-cli/src/core/devkit/commandOptions.ts

-    if (!optionItemConfig.name) {
-      optionItemConfig.name = option;
-    }
-
    optionDescritionItem = optionItemConfig;


这里应该浅拷贝一份

应该是深拷贝吧？

xqxian · 2021-09-18T09:10:33Z

packages/feflow-cli/src/core/devkit/loadDevkits.ts

-          const commandConfig = commandsConfig[command];
-          registerDevkitCommand(command, commandConfig, directoryPath, ctx);
-        }
+        const commandsConfigKey = Object.keys(commandsConfig);


用 Object.entries

packages/feflow-cli/src/core/devkit/loadDevkits.ts

xqxian · 2021-09-18T09:13:56Z

packages/feflow-cli/src/core/hook/index.ts

@@ -39,15 +34,16 @@ export default class Hook {
          this.emit(EVENT_DONE);
        });
        break;
-      default:
+      default: {


不需要加大括号吧？

xqxian · 2021-09-18T09:16:10Z

packages/feflow-cli/src/core/hook/index.ts

        const listeners = this.listeners[type];
        if (!listeners) {
          return;
        }
        this.listeners[type].forEach((listener: any) => {
-          listener.apply(null, args);
+          listener.apply(...args);


null 不能去除，逻辑改变了；args 也不能展开，第二个参数就是个数组

xqxian · 2021-09-18T09:24:41Z

packages/feflow-cli/src/core/logger/index.ts

-  async _write(data: any, enc: any, callback: any) {
-    const level = data.level;
-    const loggerName = data.name || (logger.name && logger.name.split('/').pop()) || PLUGE_NAME;
+  async newWrite(data: any, enc: any, callback: any) {


不以下划线开头就可以了吧？没必要加个 new

xqxian · 2021-09-18T09:28:08Z

packages/feflow-cli/src/core/logger/report.ts

 const { hasTimer } = process.env;
-let KYE_FILE = {};
+let KYE_FILE: any = {};


给 object 类型比较好

给object会报错

定义一个 AnyObject

xqxian · 2021-09-18T09:30:09Z

packages/feflow-cli/src/core/logger/report.ts

    console.log('send success');
  }
 }
 async function report(logObj?: any) {
-  let readData = fs.readFileSync(LOGGER_LOG_PATH, 'utf-8');
+  let readData: any = fs.readFileSync(LOGGER_LOG_PATH, 'utf-8');


这里显然是 string 类型

xqxian · 2021-09-18T09:32:39Z

packages/feflow-cli/src/core/native/config.ts

-            str += prop + ' = ' + config[prop] + '\n';
-          }
+          const configKey = Object.keys(config);
+          configKey.forEach((item: any) => {


key 和 value 都需要用时直接用 Object.entries 遍历

xqxian · 2021-09-18T09:34:59Z

packages/feflow-cli/src/core/native/help.ts

-    const desc = store[name].desc || '';
+  const arr: any = [];
+  const storeKey = Object.keys(store);
+  storeKey.forEach((item: any) => {


Object.entries

xqxian · 2021-09-18T09:40:43Z

packages/feflow-cli/src/core/native/install.ts

      const data = res.data || {};
-      return data.data && data.data[0];
+      return (data.data && data.data.length > 0 && data.data[0]) || [];


改变了原逻辑，data.data?.[0] 即可

xqxian · 2021-09-18T09:43:14Z

packages/feflow-cli/src/core/native/install.ts

@@ -64,12 +63,11 @@ async function getRepoInfo(ctx: any, packageName: string) {
 // encodeURIComponent("github.com/tencent/feflow.git")
 function getGitRepoName(repoUrl: string): string | undefined {
  const ret = /^((http:\/\/|https:\/\/)(.*?@)?|git@)/.exec(repoUrl);
+  let newRepoUrl: String = '';


初始值应为 repoUrl；String 类型应用小写

xqxian · 2021-09-18T09:45:05Z

packages/feflow-cli/src/core/native/install.ts

      }
+      ctx.logger.info(`[${dep}] has installed the latest version: ${hasInstallDep[depName]}`);
+      return [];


原逻辑没有返回空数组

xqxian · 2021-09-18T09:50:47Z

packages/feflow-cli/src/core/native/install.ts

 };

 module.exports.installPlugin = installPlugin;
-module.exports.updateUniversalPlugin = updateUniversalPlugin;


确定没有模块使用？

xqxian · 2021-09-18T09:54:29Z

packages/feflow-cli/src/core/native/list.ts

+    // for (const obj in source) {
+    //   target[obj] = source[obj];
+    // }
+    const newTarget = JSON.parse(JSON.stringify(target));


浅拷贝即可

xqxian · 2021-09-18T09:55:13Z

packages/feflow-cli/src/core/native/list.ts

+    //   target[obj] = source[obj];
+    // }
+    const newTarget = JSON.parse(JSON.stringify(target));
+    const sourceValue = Object.keys(source);


Object.entries

xqxian · 2021-09-18T09:56:04Z

packages/feflow-cli/src/core/native/list.ts

-    }
-    return target;
+  const extend = function (target: any, source: any) {
+    // for (const obj in source) {


注释掉的代码直接删除

xqxian · 2021-09-18T10:03:54Z

packages/feflow-cli/src/core/resident/update.ts

 const pkg = require('../../../package.json');
-const { getPkgInfo, updateUniversalPlugin } = require('../native/install');
-const version = pkg.version;
+// import { getPkgInfo, updateUniversalPlugin } from '../native/install';


xqxian · 2021-09-18T10:06:05Z

packages/feflow-cli/src/core/resident/updateBeat.ts

 interface ErrorInstance {
  name: string;
  message: string;
  stack: string;
 }

 const pkg = require('../../../package.json');
-const { getPkgInfo } = require('../native/install');
-const version = pkg.version;
+// import { getPkgInfo } from '../native/install';


packages/feflow-cli/src/core/resident/updateBeat.ts

xqxian · 2021-09-18T10:10:06Z

packages/feflow-cli/src/core/resident/updateBeat.ts

-    });
-    logger.debug('tnpm plugins update infomation', plugins);
-    if (plugins.length) {
+    const newPlugins = plugins.filter((plugin: any) => plugin?.name);


叫 pluginsWithName 比较语义化

packages/feflow-cli/src/core/resident/updateBeat.ts

--task=20210827

--story=20210826

xqxian · 2021-09-23T03:30:42Z

packages/feflow-cli/src/core/native/install.ts

  }: {
    logger: any;
    universalPkg: UniversalPkg;
    universalModules: string;
  } = ctx;
  const serverUrl = ctx.config?.serverUrl;

-  installPluginStr = installPluginStr.trim();
+  const newInstallPluginStr = installPluginStr.trim();


finalInstallPluginStr

xqxian · 2021-09-23T03:34:08Z

packages/feflow-cli/src/core/native/list.ts

-    }
-    return target;
+  const extend = function (target: any, source: any) {
+    const newTarget = target;


浅拷贝一下否则没有意义

…ow into refactor/20210826_fix_eslint

xqxian · 2021-09-23T03:34:47Z

packages/feflow-cli/src/core/universal-pkg/dep/base.ts

-  for (const k in oInstalled) {
-    const version = oInstalled[k];
+  Object.entries(oInstalled).forEach(([key, value]) => {
+    const version:any = value;


应为 string 类型

xqxian · 2021-09-23T03:36:46Z

packages/feflow-cli/src/core/universal-pkg/dep/base.ts

@@ -5,11 +5,11 @@ export function toInstalled(oInstalled: any): Map<string, string> {
  if (!oInstalled) {
    return installed;
  }
-  for (const k in oInstalled) {
-    const version = oInstalled[k];
+  Object.entries(oInstalled).forEach(([key, value]) => {


key 和 value 应该尽量语义化，例如 value 在最初的代码里已经明确定义为 version 了。其他类似情况不再赘述。

--story=20210826

xqxian · 2021-09-23T07:00:02Z

packages/feflow-cli/src/core/native/list.ts

@@ -9,11 +9,11 @@ function loadModuleList(ctx: any) {
  const packagePath = ctx.rootPkg;
  const pluginDir = path.join(ctx.root, 'node_modules');
  const extend = function (target: any, source: any) {
-    const newTarget = target;
+    const targetOpey = { ...target };


opey 是什么意思？叫 newTarget targetCopy 都可以

packages/feflow-cli/src/core/universal-pkg/dep/pkg.ts

--story=20210826

--task=20210923

--story=20210826

xqxian · 2021-09-24T09:38:24Z

packages/feflow-report/src/common/utils.ts

  return result;
 };

 export const getGitStatus = (): boolean => {
  const command = isWin ? 'where git' : 'which git';
  const hasGitCommand = exec(command);
  const hasGitDir = fs.existsSync(path.join(cwd, '.git'));
-  return hasGitCommand && hasGitDir;
+  return Boolean(hasGitCommand && hasGitDir);


不需要包多一层 Boolean

xqxian · 2021-09-24T09:39:44Z

packages/feflow-report/src/index.ts

@@ -10,7 +10,7 @@ class Report {
  ctx: ReportContext;
  cmd: string;
  args: object;
-  commandSource: string;
+  commandSource: string | undefined;


commandSource?: string 即可

xqxian · 2021-09-24T09:46:05Z

packages/feflow-report/src/index.ts

@@ -21,58 +21,19 @@ class Report {

  constructor(feflowContext: ReportContext, cmd?: string, args?: any) {
    this.ctx = feflowContext;
-    this.cmd = cmd;
+    this.cmd = cmd!;


cmd 可能 undefined

xqxian · 2021-09-24T09:47:13Z

packages/feflow-report/src/report.ts

@@ -28,7 +18,7 @@ function getReportBody(cmd, params): any {
    .load('command_source', commandSource)
    .load('user_name', userName)
    .load('params', params)
-    .load('err_message', getKeyFormFile(cachePath, 'errMsg'))
+    .load('err_message', getKeyFormFile(cachePath!, 'errMsg'))


不要强制断言存在，实在不会改先 ts-ignore，我后面统一优化

--story=20210826

xqxian · 2021-09-24T10:15:32Z

packages/feflow-report/src/index.ts

@@ -21,58 +21,19 @@ class Report {

  constructor(feflowContext: ReportContext, cmd?: string, args?: any) {
    this.ctx = feflowContext;
-    this.cmd = cmd;
+    this.cmd = cmd || '';


让 cmd?: string

--story=20210826

xqxian

LGTM

alexqxxu and others added 5 commits August 26, 2021 19:25

refactor: 使用腾讯 eslint 规范

1da7ba9

--task=20210826

fix: package-lock.json 被忽略提交

63340a5

--task=20210827

feat: 修复eslint代码规范

cc38a00

--story=20210826

feat: 修复eslint代码规范问题

e6438dc

--story=20210826

feat: 修复eslint代码规范问题

f051cec

--story=20210826

xqxian self-requested a review September 18, 2021 08:06

xqxian reviewed Sep 18, 2021

View reviewed changes

packages/feflow-cli/__tests__/core/logger/index.test.ts Outdated Show resolved Hide resolved

xqxian reviewed Sep 18, 2021

View reviewed changes

packages/feflow-cli/src/core/devkit/loadDevkits.ts Outdated Show resolved Hide resolved

xqxian reviewed Sep 18, 2021

View reviewed changes

packages/feflow-cli/src/core/resident/updateBeat.ts Show resolved Hide resolved

xqxian reviewed Sep 18, 2021

View reviewed changes

packages/feflow-cli/src/core/resident/updateBeat.ts Show resolved Hide resolved

alexqxxu and others added 8 commits September 23, 2021 11:20

fix: package-lock.json 被忽略提交

df7926c

--task=20210827

feat: 修复eslint代码规范

7b200d3

--story=20210826

feat: 修复eslint代码规范问题

6bb4c53

--story=20210826

feat: 修复eslint代码规范问题

c9daaea

--story=20210826

refactor: 修改cr问题

96e459d

--story=20210826

refactor: 修改cr问题

d96c0e0

--story=20210826

refactor: 解决 cr 问题

8d67d80

--story=20210826

refactor: 解决 cr 问题

f5c45e7

--story=20210826

xqxian reviewed Sep 23, 2021

View reviewed changes

Merge branch 'refactor/20210826_fix_eslint' of github.com:ljw528/fefl…

12b6132

…ow into refactor/20210826_fix_eslint

xqxian reviewed Sep 23, 2021

View reviewed changes

refactor: 解决 cr 问题

f232837

--story=20210826

xqxian reviewed Sep 23, 2021

View reviewed changes

packages/feflow-cli/src/core/universal-pkg/dep/pkg.ts Show resolved Hide resolved

v_ljiawliu and others added 5 commits September 23, 2021 15:07

refactor: 解决 cr 问题

971d714

--story=20210826

refactor: 解决 cr 问题

23ff4b9

--story=20210826

fix: ts 配置

f66c71f

--task=20210923

refactor: 解决 ts 报错

cc8a1ce

--story=20210826

refactor: 解决 lerna run test 命令的报错

43026d4

--story=20210826

xqxian reviewed Sep 24, 2021

View reviewed changes

refactor: 解决 cr 问题

168f029

--story=20210826

xqxian reviewed Sep 24, 2021

View reviewed changes

refactor: 解决 cr 问题

16c9d97

--story=20210826

xqxian approved these changes Sep 24, 2021

View reviewed changes

xqxian merged commit ae60db9 into Tencent:master Sep 24, 2021

fix eslint #378

fix eslint #378

Conversation

ljiawliu commented Sep 18, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xqxian Sep 18, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xqxian Sep 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xqxian Sep 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xqxian left a comment

Choose a reason for hiding this comment

xqxian Sep 18, 2021 •

edited

Loading

xqxian Sep 23, 2021 •

edited

Loading

xqxian Sep 23, 2021 •

edited

Loading