Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 update.json 可能不存在的问题 #393

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

codetker
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@xqxian xqxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -170,4 +175,10 @@ export default class LockFile {
err && this.logger.error(`unlock ${this.lockKey} error: `, err);
});
}

private checkFileExists(): void {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数除了检查文件是否存在,还会在不存在时自动创建,所以应该叫 ensureFileExists

@xqxian xqxian merged commit d34a520 into master Feb 17, 2022
@xqxian xqxian deleted the hotfix/修复update.json不存在报错的问题 branch February 17, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants