Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 更新 yeoman-environment v3 #434

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

gitsumsalt
Copy link
Contributor

No description provided.

@tencent-adm
Copy link
Member

tencent-adm commented Jun 6, 2023

CLA assistant check
All committers have signed the CLA.

@lininghuhu
Copy link

lininghuhu commented Jun 6, 2023 via email

@@ -36,7 +36,8 @@
},
"devDependencies": {
"@oclif/dev-cli": "^1.22.2",
"@types/nedb": "^1.8.10"
"@types/nedb": "^1.8.10",
"@types/yeoman-environment": "^2.10.8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为我们会提供 types 文件给开发者,所以第三方依赖的 types 应该放在 dependencies,跟随 feflow 一起安装,否则开发者安装后可能不能正确获得 yeoman 相关的类型提示

@gitsumsalt gitsumsalt force-pushed the feat/update-yeoman-environment branch from 0f27e89 to c9509d4 Compare June 12, 2023 11:30
Copy link
Collaborator

@xqxian xqxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xqxian xqxian added the feature label Jun 16, 2023
@xqxian xqxian changed the title feat: 更新yeoman-environment feat: 更新 yeoman-environment v3 Jun 16, 2023
@xqxian xqxian merged commit 6ece76f into Tencent:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants