Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@feflow/cli): 修复终端配置文件中 feflow bin 路径被注释时的误判 #436

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix(@feflow/cli): 修复终端配置文件中 feflow bin 路径被注释时的误判 #436

merged 1 commit into from
Jun 30, 2023

Conversation

xqxian
Copy link
Collaborator

@xqxian xqxian commented Jun 30, 2023

被注释的 export feflow bin path 命令应判断为无效，并重新添加

@xqxian
fix(@feflow/cli): 修复终端配置文件中 feflow bin 路径被注释时的误判
45dbf81 
被注释的 export feflow bin path 命令应判断为无效，并重新添加
@xqxian xqxian added the bug label Jun 30, 2023
@xqxian xqxian requested a review from blurooo June 30, 2023 09:12
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

blurooo
blurooo approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@blurooo blurooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xqxian xqxian merged commit f1c62fa into master Jun 30, 2023
@xqxian xqxian deleted the bugfix/register_commented_bin_path branch June 30, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blurooo blurooo blurooo approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xqxian @tencent-adm @blurooo