Fix text rendering error when font-family has punctuation. (#353)

* Fix text rendering error when font-family has punctuation. * Update build_web.yml
Tencent · Jun 2, 2022 · 16e815a · 16e815a
1 parent d2fe29c
commit 16e815a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/build_web.yml b/.github/workflows/build_web.yml
@@ -58,6 +58,7 @@ jobs:
           path: |
             third_party
             vendor_tools
+            web/node_node_modules
           key: third_party-web-${{ hashFiles('DEPS') }}-${{ hashFiles('vendor.json') }}
           restore-keys: third_party-web-
 
@@ -78,4 +79,4 @@ jobs:
         run: |
           cd web/script
           chmod +x build.sh
-          ./build.sh debug
+          ./build.sh
diff --git a/web/src/utils/font-family.ts b/web/src/utils/font-family.ts
@@ -16,16 +16,16 @@ export const getFontFamilies = (name: string, style = ''): string[] => {
   }
   const fontFamilies = names.reduce((pre: string[], cur: string) => {
     if (!style) {
-      pre.push(`${cur}`);
+      pre.push(`"${cur}"`);
     } else {
-      pre.push(`${cur} ${style}`);
-      pre.push(`${cur}-${style}`);
+      pre.push(`"${cur} ${style}"`);
+      pre.push(`"${cur}-${style}"`);
     }
     return pre;
   }, []);
   // Fallback font when style is not found.
   if (style !== '') {
-    fontFamilies.push(name);
-  }  
+    fontFamilies.push(`"${name}"`);
+  }
   return fontFamilies;
 };