comment

Tencent · Jul 17, 2023 · 06879cf · 06879cf
1 parent fe19e33
commit 06879cf
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/layer/x86/convolution_packed_int8.h b/src/layer/x86/convolution_packed_int8.h
@@ -926,9 +926,15 @@ static void convolution_packed_int8(const Mat& bottom_blob, Mat& top_blob, const
     const int elempack = bottom_blob.elempack;
     const int inch = bottom_blob.c * elempack;
 
+    const int N = bottom_blob.cstep * elempack;
+
+    const int outw = top_blob.w;
+    const int outh = top_blob.h;
     const int out_elempack = top_blob.elempack;
     const int outch = top_blob.c * out_elempack;
 
+    const int M = top_blob.cstep * out_elempack;
+
     const int maxk = kernel_w * kernel_h;
 
     // kernel offsets
@@ -961,6 +967,7 @@ static void convolution_packed_int8(const Mat& bottom_blob, Mat& top_blob, const
     {
         const int p = pp * 16;
 
+        // shadowed variable for less openmp task args
         const int outw = top_blob.w;
         const int outh = top_blob.h;
         const int N = bottom_blob.cstep * elempack;
@@ -1540,6 +1547,7 @@ static void convolution_packed_int8(const Mat& bottom_blob, Mat& top_blob, const
     {
         const int p = remain_outch_start + pp * 8;
 
+        // shadowed variable for less openmp task args
         const int outw = top_blob.w;
         const int outh = top_blob.h;
         const int N = bottom_blob.cstep * elempack;
@@ -2095,6 +2103,7 @@ static void convolution_packed_int8(const Mat& bottom_blob, Mat& top_blob, const
     {
         const int p = remain_outch_start + pp * 4;
 
+        // shadowed variable for less openmp task args
         const int outw = top_blob.w;
         const int outh = top_blob.h;
         const int N = bottom_blob.cstep * elempack;
@@ -2701,6 +2710,7 @@ static void convolution_packed_int8(const Mat& bottom_blob, Mat& top_blob, const
     {
         const int p = remain_outch_start + pp * 2;
 
+        // shadowed variable for less openmp task args
         const int outw = top_blob.w;
         const int outh = top_blob.h;
         const int N = bottom_blob.cstep * elempack;
@@ -3156,10 +3166,6 @@ static void convolution_packed_int8(const Mat& bottom_blob, Mat& top_blob, const
     remain_outch_start += nn_outch * 2;
     for (int p = remain_outch_start; p < outch; p++)
     {
-        const int outw = top_blob.w;
-        const int outh = top_blob.h;
-        const int N = bottom_blob.cstep * elempack;
-
         int* outptr = top_blob.channel(p);
 
         int ij = 0;