Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POWER8 VSX toolchains #4853

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Add POWER8 VSX toolchains #4853

merged 3 commits into from
Aug 6, 2023

Conversation

JeremyRand
Copy link
Contributor

POWER8, though slower than POWER9, is still used in the wild; these toolchains should still be much faster on POWER8 than POWER8 without VSX optimizations.

POWER8, though slower than POWER9, is still used in the wild; these
toolchains should still be much faster on POWER8 than POWER8 without VSX
optimizations.
@tencent-adm
Copy link
Member

tencent-adm commented Jul 12, 2023

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nihui
❌ Jeremy Rand


Jeremy Rand seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #4853 (19c063a) into master (e8645e9) will increase coverage by 0.18%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4853      +/-   ##
==========================================
+ Coverage   94.53%   94.71%   +0.18%     
==========================================
  Files         779      776       -3     
  Lines      221835   226084    +4249     
==========================================
+ Hits       209706   214136    +4430     
+ Misses      12129    11948     -181     

see 80 files with indirect coverage changes

@nihui
Copy link
Member

nihui commented Jul 13, 2023

Adding cpu model parameters to qemu can test these specific optimizations more directly

qemu-ppc64le -cpu power8_v2.0
qemu-ppc64le -cpu power9_v2.0

@JeremyRand
Copy link
Contributor Author

Adding cpu model parameters to qemu can test these specific optimizations more directly

Is this what you had in mind? (I wasn't quite sure about the syntax, hopefully I guessed right.)

@nihui nihui merged commit 0a8cf31 into Tencent:master Aug 6, 2023
7 of 9 checks passed
@nihui
Copy link
Member

nihui commented Aug 6, 2023

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants