Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan conv1d #5060

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Vulkan conv1d #5060

merged 5 commits into from
Oct 20, 2023

Conversation

FhqTreap
Copy link
Contributor

just copy vulkan conv and remove some codes, but it just works.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #5060 (d542506) into master (7b02425) will increase coverage by 0.00%.
Report is 6 commits behind head on master.
The diff coverage is 99.24%.

@@           Coverage Diff            @@
##           master    #5060    +/-   ##
========================================
  Coverage   94.80%   94.81%            
========================================
  Files         766      767     +1     
  Lines      233813   234079   +266     
========================================
+ Hits       221660   221935   +275     
+ Misses      12153    12144     -9     
Files Coverage Δ
src/layer/vulkan/convolution1d_vulkan.cpp 99.24% <99.24%> (ø)

... and 2 files with indirect coverage changes

@nihui nihui closed this Oct 11, 2023
@nihui nihui reopened this Oct 11, 2023
@FhqTreap FhqTreap mentioned this pull request Oct 11, 2023
@FhqTreap
Copy link
Contributor Author

😭

@nihui
Copy link
Member

nihui commented Oct 12, 2023

需要 merge 一下

@nihui
Copy link
Member

nihui commented Oct 12, 2023

#5079 这个 pr 怎么关掉了呢

@FhqTreap
Copy link
Contributor Author

#5079 这个 pr 怎么关掉了呢

怎么操作呢?我试过把全部代码都放一次commit里然后提交,结果跑code-format的时候也出现了一样的错误,所以我就关了。

@nihui nihui closed this Oct 20, 2023
@nihui nihui reopened this Oct 20, 2023
@nihui
Copy link
Member

nihui commented Oct 20, 2023

merge下就ok啦~

@nihui nihui merged commit dc25128 into Tencent:master Oct 20, 2023
31 checks passed
@nihui
Copy link
Member

nihui commented Oct 20, 2023

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants