Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mingw64 avx crash and termux build issue #5464

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

TianZerL
Copy link
Contributor

There is a bug for MinGW64, witch does not perform 32-byte stack alignment when it should, so avx and avx 512 may crash if we use __m256 or __m512 as function argument or return value. see here.

This PR fixed them by passing __m256 or __m512 as const reference, and for return value, we use NCNN_FORCEINLINE to make sure they will be a inline function.

ncnn build in Termux will enable Android platform API by default, but the related lib will be linked only if we are using NDK, this PR make fixed it.

@nihui nihui merged commit b0de947 into Tencent:master Jun 5, 2024
67 checks passed
@nihui
Copy link
Member

nihui commented Jun 5, 2024

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants