Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support simpleomp on Windows with MSVC #5683

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Jiang-Weibo
Copy link
Contributor

  1. Modify the CMakeLists.txt on the top level to leverage openmp on MSVC
  2. Support simpleomp on MSVC
  3. Test the results using the existed tests folder

@github-actions github-actions bot added the core label Sep 5, 2024
@tencent-adm
Copy link
Member

tencent-adm commented Sep 5, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Jiang-Weibo
❌ s2496214


s2496214 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (204583b) to head (f7c48d5).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5683      +/-   ##
==========================================
+ Coverage   94.76%   95.16%   +0.40%     
==========================================
  Files         790      793       +3     
  Lines      249195   271152   +21957     
==========================================
+ Hits       236138   258042   +21904     
- Misses      13057    13110      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiang-Weibo Jiang-Weibo closed this Sep 7, 2024
@Jiang-Weibo Jiang-Weibo reopened this Sep 7, 2024
@Jiang-Weibo Jiang-Weibo closed this Sep 8, 2024
@Jiang-Weibo Jiang-Weibo reopened this Sep 8, 2024
@Jiang-Weibo Jiang-Weibo changed the title [WIP]Support simpleomp on Windows with MSVC Support simpleomp on Windows with MSVC Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants