Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save project name on package.json #129

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

validalias
Copy link
Contributor

Hi, I've found some bugs at omi-cli.

When I create omi project with omi-cli, project name doesn't change at package.json like this.
2018-10-29 4 27 18
This is my screen shot after I run omi init text
I think it is bug, so I fix it package.json name is same as project name like this.
Sorry for my poor English. If you can't understand, leave a comment. Thx!

@dntzhang dntzhang merged commit 7881c58 into Tencent:master Oct 29, 2018
@dntzhang
Copy link
Collaborator

Good Job!

@validalias validalias deleted the omi-cli-init-method-fix branch October 29, 2018 08:10
@LeeHyungGeun
Copy link
Contributor

@validalias Awesome !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants