Skip to content

Commit

Permalink
Fix VC linkage error for CMAKE
Browse files Browse the repository at this point in the history 
Mentioned in #240
  • Loading branch information
@miloyip
miloyip committed Feb 11, 2015
1 parent 10b6a13 commit 8b3d724
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ find_package(GTestSrc)

IF(GTESTSRC_FOUND)
enable_testing()
set(gtest_force_shared_crt ON)

if (WIN32 AND (NOT CYGWIN) AND (NOT MINGW))
set(gtest_disable_pthreads ON)
Expand Down

2 comments on commit 8b3d724

@jollyroger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this line to the if() block below? This modification is totally only related for Win32 platform with VS compiler. MinGW and CygWin are ok without it as well as unix builds.

@miloyip
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks for your suggestion.

Please sign in to comment.