Parsing "128.74836467836484838364836483643636483648e-336" causes a crash

[StilesCrisis]

The number "128.74836467836484838364836483643636483648e-336" causes rapidjson::internal::GetCachedPower10 to overflow a signed integer.

Sanitizer report:
third_party/rapidjson/include/rapidjson/internal/diyfp.h:242:47: runtime error: signed integer overflow: 536870911 * 8 cannot be represented in type 'int'

[StilesCrisis]

This can lead to a segfault.

Program received signal SIGSEGV, Segmentation fault.
GetCachedPower10 (outExp=, exp=-353) at ~/github/rapidjson/include/rapidjson/internal/diyfp.h:244
244 return GetCachedPowerByIndex(index);
(gdb) bt
#0 GetCachedPower10 (outExp=, exp=-353) at ~/github/rapidjson/include/rapidjson/internal/diyfp.h:244
#1 StrtodDiyFp (result=, exp=, decimalPosition=, length=, decimals=)
at ~/github/rapidjson/include/rapidjson/internal/strtod.h:154
#2 StrtodFullPrecision (exp=-336, decimalPosition=3, length=, decimals=0x555555dfb800 "12874836467836484838364836483643636483648", p=,
d=) at ~/github/rapidjson/include/rapidjson/internal/strtod.h:259
#3 rapidjson::GenericReader<rapidjson::UTF8, rapidjson::UTF8, rapidjson::CrtAllocator>::ParseNumber<16u, rapidjson::GenericStringStream<rapidjson::UTF8 >, ParseDoubleHandler> (this=this@entry=0x7fffffffd920, is=..., handler=...) at ~/github/rapidjson/include/rapidjson/reader.h:1692
#4 0x00005555558653d7 in rapidjson::GenericReader<rapidjson::UTF8, rapidjson::UTF8, rapidjson::CrtAllocator>::ParseValue<16u, rapidjson::GenericStringStream<rapidjson::UTF8 >, ParseDoubleHandler> (this=this@entry=0x7fffffffd920, is=..., handler=...)
at ~/github/rapidjson/include/rapidjson/reader.h:1731
#5 0x0000555555865a3b in rapidjson::GenericReader<rapidjson::UTF8, rapidjson::UTF8, rapidjson::CrtAllocator>::Parse<16u, rapidjson::GenericStringStream<rapidjson::UTF8 >, ParseDoubleHandler> (this=this@entry=0x7fffffffd920, is=..., handler=...) at ~/github/rapidjson/include/rapidjson/reader.h:573
#6 0x00005555557d485e in TestParseDouble () at ~/github/rapidjson/test/unittest/readertest.cpp:247
#7 0x0000555555adf7ea in HandleSehExceptionsInMethodIfSupported<testing::Test, void> (location=0x555555b0f41a "the test body", method=, object=0x555555dd0d40)
at ~/github/rapidjson/thirdparty/gtest/googletest/src/gtest.cc:2402

[StilesCrisis]

Unit test demonstrating the behavior is now in #1252

[miloyip]

Fixed in #1290