-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Build(issue #82) #126
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its CMake scripts.
Currently thirdparty/gtest is a Git submodule, is it possible to not adding gtest files in this pull request? |
if(RapidJSON_ENDIANNESS STREQUAL "Little") | ||
list(APPEND | ||
RapidJSON_DEFINITIONS | ||
"-DRAPIDJSON_ENDIAN=0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use RAPIDJSON_BIGENDIAN
and RAPIDJSON_LITTLEENDIAN
instead of hard-coding 0 and 1.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for CMake build system support in RapidJSON. (issue #82)
It includes build scripts for examples, unittests, and a CMake module of RapidJSON.
Usage:
For some version of Visual C++ on Windows, you may need to check
gtest_force_shared_crt
to ensure projects are linked to same type of CRT(multi-threaded dynamic).Differences from current build system(premake):
Code Generation Settings
In premake build scripts, project test and project example have inconsistent code generation settings. In project test SSE4.2(-msse4.2) is enabled only for gmake configuration.While in project example, SSE2(flags { "Optimize", "EnableSSE2" }) is enabled for release configuration.
Currently I leave the SSE optimization settings unset for both project unittest and project example.
This does not affect the intrinsic sets you use(which is controlled by CMake variable
RapidJSON_SIMD_OPTIMIZATION
).Working Directory
For Visual C++ you should set working directory manually because CMake cannot set it in an official documented way.
Please delay merging of this pull request. I have to test this on Xcode on a Mac OS X machine.