Improve setting default build type for CMake #1519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the Release as default build type. Switch to the Debug as default for development, when building locally from Git repository, unless building on CI job. Do not set CMAKE_BUILD_TYPE for multi configuration generators. Follows https://blog.kitware.com/cmake-and-the-default-build-type/ Improves #319
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the
Releaseas default build type.Switch to the
Debugas default for development, when building locally from Git repository, unless building on CI job.Do not set
CMAKE_BUILD_TYPEfor multi configuration generators.Follows https://blog.kitware.com/cmake-and-the-default-build-type/
Improves #319