Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: avoid Valgrind bug with '-march=native' #171

Merged
merged 1 commit into from
Oct 24, 2014

Conversation

pah
Copy link
Contributor

@pah pah commented Oct 23, 2014

The switch in #163 to -march=native exposed a Valgrind bug on the Travis CI machines, see e.g. build 436 and following:

vex amd64->IR: unhandled instruction bytes: 0xC4 0xE1 0xFB 0x2A 0x45 0x80 0xEB 0x1A
==3841== valgrind: Unrecognised instruction at address 0x418d6b.

Possibly fixed in Valgrind 3.10, see upstream bug https://bugs.kde.org/show_bug.cgi?id=326469.

This pull-request temporarily changes the -march=native flags back to -msse4.2 after the generation of the gmake files. I still think that the original change in #163 is reasonable.

@spl
Copy link
Contributor

spl commented Oct 23, 2014

Wow, interesting. Did I miss that in the Travis results of #163? I don't remember seeing any issues.

@pah
Copy link
Contributor Author

pah commented Oct 23, 2014

It seems, #163 has never been built on Travis CI…

@lichray
Copy link
Contributor

lichray commented Oct 23, 2014

Cannot even find a PPA for valgrind 3.10. I rebase my change on this PR :(

miloyip added a commit that referenced this pull request Oct 24, 2014
.travis.yml: avoid Valgrind bug with '-march=native'
@miloyip miloyip merged commit 11f20c4 into Tencent:master Oct 24, 2014
@pah pah deleted the fixes/travis-valgrind-bug branch October 24, 2014 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants