Make stream local copy optimization as trait option per stream type #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unit test is added
‘>>’ should be ‘> >’ within a nested template argument list
need ‘typename’ before ‘rapidjson::StreamTraits<InputStream>::StreamCopyType
miloyip
added a commit
that referenced
this pull request
Jun 29, 2014
Make stream local copy optimization as trait option per stream type
miloyip
added a commit
that referenced
this pull request
Jul 2, 2014
The previous optimization #32 has problem that restoration requires assignment operator. Change the backup/restore process using a template wrapper class to select code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By Adding StreamTraits, stream types can specify whether to turn on local copy optimization.
Added unit test to verify that a Stream without copy constructor do not use this optimization by default. Turning it on will generate compilation error.
Fixes #30