Code

Fix undefined behaviour#646

Code

Merged

miloyip merged 16 commits intoTencent:masterTencent/rapidjson:masterfrom efidler:ubsanefidler/rapidjson:ubsanCopy head branch name to clipboardJun 15, 2016

+106-28

Commits

Commits on Jun 13, 2016

• support building with ASAN and UBSAN on Clang and GCC

  efidler

  committed
  56bb999

• Clang doesn't like the C-style casts in nmmintrin.h

  efidler

  committed
  89f6b8a

• we do need to avoid the double-promotion warning on clang, since we're compiling with -Werror

  efidler

  committed
  13e3aa9

• with recent clang, when expected is false, this code triggers -Wunreachable-code

  Show description for 0352710
  efidler

  committed
  0352710

• with recent clang, this triggers -Wunevaluated-expression

  Show description for 5c77c92
  efidler

  committed
  5c77c92

• avoid array index out-of-bounds

  Show description for fe550f3
  efidler

  committed
  fe550f3

• avoid reference to null pointer and member access within null pointer

  Show description for 8074b72
  efidler

  committed
  8074b72

• avoid passing a null pointer to memcpy

  Show description for 61637d3
  efidler

  committed
  61637d3

Commits on Jun 14, 2016

• avoid signed-integer overflow, which is undefined behavior

  Show description for be1eedf
  efidler

  committed
  be1eedf

• avoid signed-integer underflow, which is undefined behavior

  Show description for 760ea43
  efidler

  committed
  760ea43

• avoid division by zero, which is undefined behavior

  Show description for df9b45a
  efidler

  committed
  df9b45a

• avoid shift out-of-range error

  Show description for 9dcf51c
  efidler

  committed
  9dcf51c

• avoid shift out-of-range error

  Show description for 05f0592
  efidler

  committed
  05f0592

• fix undefined double to uint64_t cast

  Show description for c52cec7
  efidler

  committed
  c52cec7

• range check in IsLosslessFloat to avoid undefined double->float cast

  Show description for 21acc56
  efidler

  committed
  21acc56

• test for no-double-promotion instead of just checking compiler version

  efidler

  committed
  8c40597