Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on GCC 6 and later (closes #666) #667

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Conversation

pah
Copy link
Contributor

@pah pah commented Jun 23, 2016

This pull-request fixes the warnings on GCC 6 and later as reported in #666 and validated locally.

  • document.h
    • suppress -Wterminate on GCC 6.x and later
    • simplify warning handling
  • schema.h
    • drop RAPIDJSON_NOEXCEPT from GenericSchemaDocument constructor (calls RAPIDJSON_NEW anyway)
    • simplify warning handling (avoids RAPIDJSON_POP mismatch on Clang)
  • encodingtest.cpp, istreamwrappertest.cpp
    • work around -Wdangling-else
  • readertest.cpp
    • suppress -Wdangling-else

* document.h
  * suppress -Wterminate on GCC 6.x and later
  * simplify warning handling
* schema.h
  * drop RAPIDJSON_NOEXCEPT from GenericSchemaDocument constructor
    (calls RAPIDJSON_NEW anyway)
  * simplify warning handling
    (avoids RAPIDJSON_POP mismatch on Clang)
* encodingtest.cpp, istreamwrappertest.cpp
  * work around -Wdangling-else
* readertest.cpp
  * suppress -Wdangling-else
@coveralls
Copy link

coveralls commented Jun 23, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f6a0769 on pah:fixes/666 into 1c087b7 on miloyip:master.

@miloyip miloyip merged commit 6da9227 into Tencent:master Jun 27, 2016
@miloyip
Copy link
Collaborator

miloyip commented Jun 27, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants