-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/drawer #271
Feature/drawer #271
Conversation
# Conflicts: # site/mobile/mobile.config.js # site/web/site.config.js # src/index.ts
与tdesgin-mobile-vue对齐,新增了drawer组件的基础功能,实现了基本的props与methods
代码冲突了,记得处理下 |
冲突已修复,src/_common改动是pull其他分支变更的代码,未做过修改 |
还是冲突。你应该合并 develop 处理下 |
merge code
merge src/index.ts to develop branch
merge index.ts conflicts
change index.ts to same
src/index.ts为解决冲突,目前已与devlop分支保持一致。 |
Codecov Report
@@ Coverage Diff @@
## develop #271 +/- ##
=========================================
Coverage ? 7.16%
=========================================
Files ? 383
Lines ? 4134
Branches ? 969
=========================================
Hits ? 296
Misses ? 3838
Partials ? 0 Continue to review full report at Codecov.
|
CI 挂了,麻烦关注一下 |
已重新推送,CI中有一条src/index.ts未导出Drawer,我这里没有写入权限,修改就会直接报文件冲突,不修改CI会报Drawer未全局导出,麻烦管理员手动添加一下这里 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤔 这个 PR 的性质是?
🔗 相关 Issue
暂无
💡 需求背景和解决方案
与tdesign-mobile-vue对齐,实现Drawer抽屉组件
📝 更新日志
feat(Drawer): 新增抽屉组件
[] 本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单