Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid-item): explore grid-item to pass props #293

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

ZWkang
Copy link
Collaborator

@ZWkang ZWkang commented Sep 30, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

扩展 grid-item 的 props 使其支持 onClick 等事件
fix #291

📝 更新日志

  • feat(Grid): 透传所有非定义的 props 至根元素

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ZWkang
Copy link
Collaborator Author

ZWkang commented Sep 30, 2022

cc @LeeJim

@github-actions
Copy link
Contributor

完成

@codecov-commenter
Copy link

Codecov Report

Merging #293 (2461845) into develop (6108f18) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop    #293      +/-   ##
==========================================
- Coverage     7.20%   7.20%   -0.01%     
==========================================
  Files          383     383              
  Lines         4134    4135       +1     
  Branches       969     969              
==========================================
  Hits           298     298              
- Misses        3836    3837       +1     
Impacted Files Coverage Δ
src/grid/GridItem.tsx 13.15% <0.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJim LeeJim merged commit feddd17 into Tencent:develop Oct 25, 2022
@github-actions github-actions bot mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GridItem] 缺失点击事件
3 participants