Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Image): refactoring completed #470

Merged
merged 3 commits into from
Aug 20, 2024
Merged

feat(Image): refactoring completed #470

merged 3 commits into from
Aug 20, 2024

Conversation

anlyyao
Copy link
Collaborator

@anlyyao anlyyao commented Aug 19, 2024 •
edited
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

相关PR

Tencent/tdesign-common#1886

💡 需求背景和解决方案

📝 更新日志

  • feat(Image): 新增 referrerpolicy 和 fallback 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

完成

HaixingOoO
HaixingOoO reviewed Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loading and error type to TNode use parseTNode render?

HaixingOoO
HaixingOoO reviewed Aug 19, 2024
View reviewed changes
src/image/Image.tsx Outdated Show resolved Hide resolved
@anlyyao
Copy link
Collaborator Author

anlyyao commented Aug 19, 2024

loading and error type to TNode use parseTNode render?

why not？

No need to support () => ReactNode?

@HaixingOoO
Copy link
Collaborator

loading and error type to TNode use parseTNode render?

why not？

No need to support () => ReactNode?

ok, less content to read🤣

@HaixingOoO
Copy link
Collaborator

其他沒問題了，就是有個場景我要測試一下先

HaixingOoO
HaixingOoO reviewed Aug 20, 2024
View reviewed changes
src/image/Image.tsx Outdated Show resolved Hide resolved
@HaixingOoO
Copy link
Collaborator

image
我看到的加載的狀態是乱的，你们可以设置onLoad延迟触发查看

@HaixingOoO
Copy link
Collaborator

然后现在的lazy模式有问题，应该是到可视区域才会加载图片，但现在的方式是已经默认加载图片了，可打印onLoad和onError查看

@HaixingOoO
Copy link
Collaborator

image 我看到的加載的狀態是乱的，你们可以设置onLoad延迟触发查看

image

loading例子的樣式問題

@anlyyao
Copy link
Collaborator Author

anlyyao commented Aug 20, 2024 •
edited
Loading

@HaixingOoO 示例样式已处理，lazy 属性无效问题已修复

@anlyyao anlyyao requested a review from HaixingOoO August 20, 2024 06:23
@anlyyao anlyyao mentioned this pull request Aug 20, 2024
Open
HaixingOoO
HaixingOoO reviewed Aug 20, 2024
View reviewed changes
src/image/Image.tsx Outdated Show resolved Hide resolved
@anlyyao anlyyao requested a review from HaixingOoO August 20, 2024 07:02
@HaixingOoO
Copy link
Collaborator

approved

@anlyyao
Copy link
Collaborator Author

anlyyao commented Aug 20, 2024

approved

谢谢大哥👀

@anlyyao anlyyao merged commit 839aa44 into develop Aug 20, 2024
6 checks passed
@anlyyao anlyyao deleted the feat/image branch August 20, 2024 07:09
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaixingOoO HaixingOoO HaixingOoO approved these changes

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

@jarmywang jarmywang Awaiting requested review from jarmywang jarmywang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anlyyao @HaixingOoO