Skip to content

Commit

Permalink
feat(card): replace title span with div (#2517)
Browse files Browse the repository at this point in the history
  • Loading branch information
@uyarn
uyarn authored Sep 19, 2023
1 parent 495ddd0 commit 7be1adc
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 59 deletions.
4 changes: 2 additions & 2 deletions src/card/Card.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ const Card = forwardRef<HTMLDivElement, CardProps>((props, ref) => {
[`${classPrefix}-card__description`]: description,
});

const renderTitle = title ? <span className={titleClass}>{title}</span> : null;
const renderTitle = title ? <div className={titleClass}>{title}</div> : null;

const renderSubtitle = subtitle ? <span className={subtitleClass}>{subtitle}</span> : null;
const renderSubtitle = subtitle ? <div className={subtitleClass}>{subtitle}</div> : null;

const renderDescription = description ? <p className={descriptionClass}>{description}</p> : null;

Expand Down
96 changes: 48 additions & 48 deletions test/snap/__snapshots__/csr.test.jsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38710,11 +38710,11 @@ exports[`csr snapshot test > csr test src/card/_example/base.jsx 1`] = `
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -38743,11 +38743,11 @@ exports[`csr snapshot test > csr test src/card/_example/base.jsx 1`] = `
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -38919,11 +38919,11 @@ exports[`csr snapshot test > csr test src/card/_example/bordered-none.jsx 1`] =
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -38960,11 +38960,11 @@ exports[`csr snapshot test > csr test src/card/_example/bordered-none.jsx 1`] =
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -40615,11 +40615,11 @@ exports[`csr snapshot test > csr test src/card/_example/header.jsx 1`] = `
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -40652,11 +40652,11 @@ exports[`csr snapshot test > csr test src/card/_example/header.jsx 1`] = `
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -40750,16 +40750,16 @@ exports[`csr snapshot test > csr test src/card/_example/header-all-props.jsx 1`]
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
<span
</div>
<div
class="t-card__subtitle"
>
副标题
</span>
</div>
<p
class="t-card__description"
>
Expand Down Expand Up @@ -40793,16 +40793,16 @@ exports[`csr snapshot test > csr test src/card/_example/header-all-props.jsx 1`]
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
<span
</div>
<div
class="t-card__subtitle"
>
副标题
</span>
</div>
<p
class="t-card__description"
>
Expand Down Expand Up @@ -40897,11 +40897,11 @@ exports[`csr snapshot test > csr test src/card/_example/header-bordered.jsx 1`]
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -40934,11 +40934,11 @@ exports[`csr snapshot test > csr test src/card/_example/header-bordered.jsx 1`]
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -41032,11 +41032,11 @@ exports[`csr snapshot test > csr test src/card/_example/header-description.jsx 1
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
<p
class="t-card__description"
>
Expand Down Expand Up @@ -41070,11 +41070,11 @@ exports[`csr snapshot test > csr test src/card/_example/header-description.jsx 1
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
<p
class="t-card__description"
>
Expand Down Expand Up @@ -41218,11 +41218,11 @@ exports[`csr snapshot test > csr test src/card/_example/header-footer-actions.js
</div>
</div>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
<p
class="t-card__description"
>
Expand Down Expand Up @@ -41423,11 +41423,11 @@ exports[`csr snapshot test > csr test src/card/_example/header-footer-actions.js
</div>
</div>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
</div>
<p
class="t-card__description"
>
Expand Down Expand Up @@ -41640,16 +41640,16 @@ exports[`csr snapshot test > csr test src/card/_example/header-subtitle.jsx 1`]
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
<span
</div>
<div
class="t-card__subtitle"
>
副标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -41678,16 +41678,16 @@ exports[`csr snapshot test > csr test src/card/_example/header-subtitle.jsx 1`]
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
<span
</div>
<div
class="t-card__subtitle"
>
副标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -41777,16 +41777,16 @@ exports[`csr snapshot test > csr test src/card/_example/header-subtitle-footer-a
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
<span
</div>
<div
class="t-card__subtitle"
>
副标题
</span>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -41933,16 +41933,16 @@ exports[`csr snapshot test > csr test src/card/_example/header-subtitle-footer-a
class="t-card__header-wrapper"
>
<div>
<span
<div
class="t-card__title"
>
标题
</span>
<span
</div>
<div
class="t-card__subtitle"
>
副标题
</span>
</div>
</div>
</div>
<div
Expand Down
Loading

0 comments on commit 7be1adc

Please sign in to comment.