feat(tree): add Tree onScroll api #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaixingOoO
requested review from
honkinglin,
uyarn,
carolin913,
NWYLZW and
ZWkang
as code owners
|
|
uyarn
approved these changes
Dec 23, 2024
| @@ -238,7 +238,7 @@ export interface TdTreeProps<T extends TreeOptionData = TreeOptionData> { | |||
| /** | |||
| * 滚动事件 | |||
| */ | |||
| onScroll?: (params: { e: WheelEvent<HTMLDivElement> }) => void; | |||
| onScroll?: (params: { e: WheelEvent }) => void; | |||
There was a problem hiding this comment.
同步API 会有覆盖问题，默认带出的<HTMLDivElement>
There was a problem hiding this comment.
@uyarn 大佬看看是vue和react一样？还是怎么统一？
This was referenced Dec 25, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
TreesupportonScrollapi📝 更新日志
feat(Tree): support
onScrollapi本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单