Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): src = File error triggered handleError (#3448) #4102

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

XBIsland
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

背景:
src = File 时通过 useImagePreviewUrl 获取 previewUrl,由于异步的原因,执行 renderImage()
previewUrl 为空,触发了 handleError 逻辑导致 loading 视图没有展示。

方案:
useImagePreviewUrl 增加了 loading 标识是否加载完 previewUrl

📝 更新日志

  • fix(image): 修复了 src = Fileloading 视图没有展示。

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

失败

@XBIsland
Copy link
Contributor Author

有几张测试图片挂了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant