Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Table): handle null values in isFilterValueExist #4829

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(Table): handle null values in isFilterValueExist #4829

merged 1 commit into from
Dec 12, 2024

Conversation

HHaoWang
Copy link
Contributor

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

表格组件在有筛选项时如果清除筛选，会直接报错，无法进行清除操作

image

经查是由于useFilter.tsx中isFilterValueExist里isObjectTrue判断缺失对null值的处理

📝 更新日志

  • fix(table): 修复isFilterValueExist无法正常处理null值导致无法正常清除筛选的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn uyarn changed the title fix(table): handle null values in isFilterValueExist fix(Table): handle null values in isFilterValueExist Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

完成

@uyarn uyarn merged commit c092cd5 into Tencent:develop Dec 12, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Dec 31, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HHaoWang @uyarn