Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ImageViewer] 预览滚轮缩放风格 #2825

Closed
raohuiyong opened this issue Sep 27, 2023 · 4 comments
Closed

[ImageViewer] 预览滚轮缩放风格 #2825

raohuiyong opened this issue Sep 27, 2023 · 4 comments
Labels
IssueShoot middle middle level of difficulties to be published fixed, not be published

Comments

@raohuiyong
Copy link

raohuiyong commented Sep 27, 2023 •
edited by github-actions bot
Loading

这个功能解决了什么问题

适配windows使用习惯，在windows中滚轮向前是放大，滚轮向内是缩小。目前预览时却是相反的，使用起来体验不是很好

你建议的方案是什么

内部代码处理滚轮缩放事件时，根据使用的系统（mac或windows）进行滚轮放大和缩小的逻辑处理

IssueShoot

  • 预估时长: 3
  • 期望完成时间: 2023-12-14 00:00:00 +0000 UTC
  • 开发难度: 中
  • 参与人数: 1
  • 验收标准: 实现期望改造效果，提 PR 并通过验收无误
  • 备注: 最终激励以实际提交 pull request 并合并为准
@github-actions
Copy link
Contributor

👋 @raohuiyong，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

♥️ 有劳 @sinbadmaster 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @raohuiyong 。

@Barry-Flynn
Copy link

这个建议我在2022年6月提过（#1826），当时好像说有待讨论，至今无下文...哈哈

@uyarn uyarn added IssueShoot middle middle level of difficulties labels Dec 7, 2023
sinbadmaster added a commit to sinbadmaster/tdesign-vue that referenced this issue Dec 12, 2023
@sinbadmaster
fix(image-viewer): 滚轮缩放符合操作直觉
50652f2 
自然滚动与标准滚动对图片放大缩小的操作均符合直觉

Tencent#2825
@sinbadmaster sinbadmaster mentioned this issue Dec 12, 2023
Merged
16 tasks
uyarn pushed a commit that referenced this issue Dec 12, 2023
@sinbadmaster
fix(image-viewer): 滚轮缩放符合操作直觉 (#2974)
8a37ecf 
自然滚动与标准滚动对图片放大缩小的操作均符合直觉

#2825
@uyarn uyarn added the to be published fixed, not be published label Dec 12, 2023
@uyarn uyarn closed this as completed Dec 12, 2023
@uyarn uyarn reopened this Dec 12, 2023
@uyarn uyarn closed this as completed Dec 12, 2023
@uyarn uyarn mentioned this issue Dec 13, 2023
Merged
16 tasks
uyarn pushed a commit that referenced this issue Dec 15, 2023
@sinbadmaster @uyarn
fix(image-viewer): 滚轮缩放符合操作直觉 (#2974)
c7c00c1 
自然滚动与标准滚动对图片放大缩小的操作均符合直觉

#2825
uyarn added a commit that referenced this issue Dec 15, 2023
@uyarn @liweijie0812
@chaishi @oljc @hkaikai @PengYYYYY @betavs @TabSpace @ZWkang @anlyyao @sinbadmaster @github-actions @Lyan-u
chore: release 1.8.3-naruto (#2989)
e92a880 
* refactor: radio/checkbox选中判断改回正则 (#2927)

* fix(table): row-edit event not trigger (#2934)

* fix(statistic): fix with missing default precision (#2933)

* fix(radio): 选项内容变化后样式问题修复 (#2936)

fix #2930

* feat: cascader value-display (#2938)

* feat: 增加 cascader 对 valueDisplay 的支持

* test: update snap

* fix(pagination): when total is 0 and pageSize change, current value is 0 (#2937)

* fix(tree): tree 节点禁用状态逻辑改进 (#2935)

* test(tree): 完善 tree 组件的禁用示例

* fix(tree): tree 组件, 禁用状态过滤函数不再仅生效于UI层，将传递到模型侧参与状态计算

* fix(tree): tree 组件完善禁用逻辑

* fix(tree): tree 组件添加 refresh 方法刷新节点状态

* test(tree): tree 组件，完善 disabled 相关示例

* fix(tree): tree 组件，完善半选状态下的状态切换

* test(tree): tree 组件，完善操作示例，提供 disabled 状态与其他状态的整合演示

* chore(tree): tree 组件，更新 common 依赖

* test(tree): tree 组件，添加禁用状态相关测试

* chore(tree): tree 组件，更新 common 依赖，补充文档

* test(tree): tree 组件，update snapshot

* fix(auto-complete): using lodash escapeRegExp transform keyword text (#2943)

* fix(auto-complete): using lodash escapeRegExp transform keyword text

* docs(auto-complete): update auto-complete custom filter example

* chore: update contributing (#2950)

* chore: update contributing

* chore: update docs

* fix(tree): tree 组件, value, active, expanded 属性, 支持数组操作触发视图变更 (#2951)

* fix(tree): tree 组件, value, active, expanded 属性, 支持数组操作触发视图变更

* refactor(tree): tree 组件,改进属性监听代码结构

* fix(tree): tree 组件，解决 value 传递 undefined，可能导致视图操作报错的问题

* ci: add workflow for issue label (#2953)

* fix(table): pagination (#2954)

* fix(image-viewer): 修改键盘事件绑定对象 (#2958)

* feat(Table): fix some pagination problems (#2962)

* feat(table): pagination

* feat: code save

* fix(table): pagination

* fix: row select and drag sort

* docs(table): demo

* feat(menu): close menu after clicking (#2963)

* feat(tabs): scroll to better position when active tab is in middle (#2964)

* chore: release 1.8.1 (#2965)

* chore: release 1.8.1

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat(upload): uploadPastedFiles (#2966)

* fix(tree): the height attribute does not work (#2968)

* fix(tree): the height attribute does not work

* test(tree): the height attribute does not work

* chore: update publish frequency descriptions (#2969)

* chore: update Publish.md

* chore: fix table test

* chore: update PUBLISH.md

* fix(image-viewer): 滚轮缩放符合操作直觉 (#2974)

自然滚动与标准滚动对图片放大缩小的操作均符合直觉

#2825

* fix(date-range-picker): 修复12月时选择同一个月内的日期后，第一次打开面板左右月份一样的问题 (#2972)

* fix(drawer): unable to close by click on escape (#2967)

* chore: fix ssr error (#2985)

* chore: release 1.8.2 (#2986)

* chore: release 1.8.2

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: release 1.8.3 (#2988)

* chore: release 1.8.3

* chore: release 1.8.3

* chore: release 1.8.3

* chore: release 1.8.3-naruto

---------

Co-authored-by: liweijie0812 <674416404@qq.com>
Co-authored-by: sheepluo <yaoyanhuoyi@qq.com>
Co-authored-by: 李江辰 <SpaceCode@foxmail.com>
Co-authored-by: hkaikai <617760820@qq.com>
Co-authored-by: PY <pengyue970715@gmail.com>
Co-authored-by: betavs <34408516+betavs@users.noreply.github.com>
Co-authored-by: TabSpace <pillar0514@163.com>
Co-authored-by: kang <kang95630@gmail.com>
Co-authored-by: Y <anllyyao@gmail.com>
Co-authored-by: sinbadmaster <40019023+sinbadmaster@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lyan-u <46185702+Lyan-u@users.noreply.github.com>
@uyarn
Copy link
Collaborator

uyarn commented Dec 15, 2023

optimized 1.8.3

@uyarn uyarn reopened this Dec 15, 2023
@uyarn uyarn closed this as completed Dec 15, 2023
@Barry-Flynn Barry-Flynn mentioned this issue Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IssueShoot middle middle level of difficulties to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raohuiyong @uyarn @Barry-Flynn