fix(select): checkAll will check all filtered data of reserveKeyword
#3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`reserveKeyword`
RSS1102
requested review from
chaishi,
uyarn,
xiaosansiji,
maoyiluo,
liweijie0812 and
LoopZhou
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
befor:
在
multiple、filterable和reserveKeyword的状态下，筛选数据之后，进行全选会选中 当前 filter 之后的数据，但是不能再次点击 全选 进行取消选择(全选)。now:
在
multiple、filterable和reserveKeyword的状态下，筛选数据之后，进行全选会选中 当前 filter 之后的数据，但是再次点击 全选 进行取消选择(全选)。将部分在点击全选的方法进行抽离到公共函数内调用，保持代码简洁和复用。
Tip
目前看起来似乎不是一个 breaking change，不会对之前的逻辑产生影响，更像一个错误的修复。
📝 更新日志
fix(select): 在保留关键字的情况下使用筛选，全选会对于筛选后的
options进行操作和比较。本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单