Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adapt bcs-cpuset-device to kubernetes #924 #925

Merged
merged 4 commits into from
Jun 24, 2021
Merged

feature: adapt bcs-cpuset-device to kubernetes #924 #925

merged 4 commits into from
Jun 24, 2021

Conversation

abstractmj
Copy link
Collaborator

No description provided.

@DeveloperJim DeveloperJim self-assigned this Jun 21, 2021
@DeveloperJim DeveloperJim added this to the 1.21.x milestone Jun 21, 2021
@DeveloperJim DeveloperJim added confirmed issue is confirmed feature new feature k8s inner issue comes from Tencent side labels Jun 21, 2021
Copy link
Collaborator

@DeveloperJim DeveloperJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -329,7 +392,17 @@ func (c *CpusetDevicePlugin) GetDevicePluginOptions(context.Context, *pluginapi.

// ListAndWatch lists devices and update that list according to the health status
func (c *CpusetDevicePlugin) ListAndWatch(e *pluginapi.Empty, s pluginapi.DevicePlugin_ListAndWatchServer) error {
return s.Send(&pluginapi.ListAndWatchResponse{Devices: c.devices})
ticker := time.NewTicker(360 * time.Second)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ticker需要保障关闭

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修复

@DeveloperJim DeveloperJim merged commit f08de42 into TencentBlueKing:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed issue is confirmed feature new feature inner issue comes from Tencent side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants