Pass TerminalView's autofocus to the InputListener that it creates. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that setting autofocus=true in the TerminalView constructor didn't seem to cause the TerminalView to take focus, but when I made this change to pass the TerminalView's autofocus setting down to the InputListener, it worked - the TerminalView took focus when my app started (on Linux and web).
At the point of change, the InputListener autofocus was intentionally set to false (and had at one time been true), but this may have been done before there was a TerminalView autofocus value to use there.
This change should have no effect when the TerminalView's autofocus is false (the default).