#26: Fixed Update check to dont depend on locale

Terminals-Origin · Jun 16, 2017 · 0fb4fd2 · 0fb4fd2
1 parent 81d59b0
commit 0fb4fd2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/Source/Terminals/Updates/UpdateChecksFile.cs b/Source/Terminals/Updates/UpdateChecksFile.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.IO;
 using Terminals.Configuration;
 
@@ -19,7 +20,7 @@ internal bool ShouldCheckForUpdate
                 if (File.Exists(releaseFile))
                 {
                     DateTime lastUpdate = this.ReadLastUpdate();
-                    if (lastUpdate.Date >= DateTime.Now.Date)
+                    if (lastUpdate.Date >= DateTime.UtcNow.Date)
                         return false;
                 }
                 return true;
@@ -30,13 +31,14 @@ internal DateTime ReadLastUpdate()
         {
             String text = File.ReadAllText(this.releaseFile).Trim();
             DateTime lastUpdate = DateTime.MinValue;
-            DateTime.TryParse(text, out lastUpdate);
+            DateTime.TryParse(text, CultureInfo.InvariantCulture, DateTimeStyles.AdjustToUniversal,  out lastUpdate);
             return lastUpdate;
         }
 
         internal void WriteLastCheck()
         {
-            File.WriteAllText(this.releaseFile, DateTime.Now.ToString());
+            string contents = DateTime.UtcNow.ToString(CultureInfo.InvariantCulture);
+            File.WriteAllText(this.releaseFile, contents);
         }
     }
 }
diff --git a/Source/Tests/UpdateManagerTest.cs b/Source/Tests/UpdateManagerTest.cs
@@ -20,7 +20,7 @@ public class UpdateManagerTest
     {
         private Version currentVersion = new Version(2, 0, 0);
 
-        private readonly DateTime yesterDay = DateTime.Today.AddDays(-1);
+        private readonly DateTime yesterDay = DateTime.UtcNow.Date.AddDays(-1);
 
         [TestInitialize]
         public void ConfigureTestLab()
@@ -57,7 +57,7 @@ public void OldestBuildDate_CheckForCodeplexRelease_ReturnsValidRelease()
         [TestMethod]
         public void TodayCheckedDate_CheckForCodeplexRelease_DoesnotUpdateCheckDate()
         {
-            var previousCheck = DateTime.Today;
+            var previousCheck = DateTime.UtcNow.Date;
             File.WriteAllText(FileLocations.LastUpdateCheck, previousCheck.ToString(CultureInfo.InvariantCulture));
             ReleaseInfo checkResult = this.RunUpdateCheck();