fix: Add scope to Place & Story Model to filter out null coords (v2) #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudokemper
changed the title
lauramosher
approved these changes
Oct 7, 2023
|
You'll need to ♻️ rebase to resolve the conflicts |
rudokemper
force-pushed
the
rk/filter-places-null-coords-2
branch
from
f0ab4af
to
98864be
Compare
|
Ugh, gotta change my line ending settings for the repo -_- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a scope to the Place and Story Models to filter out any places that have null coordinates (primarily for the front end of TS Main and Explore).
Although we are currently requiring lat/long fields when creating a new Place in the CMS, the Importer currently permits the user to upload Places without lat/longs, hence introducing a bug where Places without lat/long are passed on to React.
We are now adding the stories associated with the communities when they are fetched, not when they are filtered.
In the future we need to rework the Importer as a whole, but that's a whole 'nother epic.