Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow some basic HTML tags in story description #962

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Allow some basic HTML tags in story description #962

merged 1 commit into from
Nov 7, 2023

Conversation

julinvictus
Copy link
Contributor

@julinvictus julinvictus commented Sep 29, 2023 •
edited
Loading

Screen Shot 2023-09-28 at 4 01 03 PM Screen Shot 2023-09-28 at 4 02 35 PM Screen Shot 2023-09-28 at 6 11 19 PM Screen Shot 2023-11-01 at 7 26 19 PM

@julinvictus julinvictus self-assigned this Sep 29, 2023
@julinvictus julinvictus linked an issue Sep 29, 2023 that may be closed by this pull request
[Rails] Allow some basic HTML tags in story description (em, strong, a) #949
Closed
2 tasks
@rudokemper
Copy link
Member

Nice work, @julinvictus!

Can you make this work on the React side as well?

rudokemper
rudokemper approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@rudokemper rudokemper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll just need to make sure this also works in the React front end. I think it'd be fine to accept this as-is, but to merge we should first do a follow-up PR, or amend this PR to also get the HTML tag working in React.

@julinvictus
Copy link
Contributor Author

Looks good! We'll just need to make sure this also works in the React front end. I think it'd be fine to accept this as-is, but to merge we should first do a follow-up PR, or amend this PR to also get the HTML tag working in React.

I can take a look at the react part

@julinvictus
Copy link
Contributor Author

When you say React you mean this part here, right?
Screen Shot 2023-10-16 at 7 47 31 PM

@rudokemper
Copy link
Member

Correct

@julinvictus julinvictus merged commit 8db60fa into master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudokemper rudokemper Awaiting requested review from rudokemper

Assignees

@julinvictus julinvictus

Labels
Hacktoberfest Hacktoberfest 2023 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rails] Allow some basic HTML tags in story description (em, strong, a)
2 participants
@julinvictus @rudokemper