issue 948 - title tags update #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rudokemper
previously requested changes
Oct 6, 2023
| @@ -1,7 +1,7 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <title>Terrastories</title> | |||
| <title>Terrastories - <%= @community.name %></title> | |||
There was a problem hiding this comment.
Set this to Terrastories: <%= @community.name %></title>
lauramosher
requested changes
Oct 7, 2023
| @@ -1,7 +1,7 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <title>Terrastories</title> | |||
| <title>Welcome - Terrastories<%= @community ? ': ' + @community.name : '' %></title> | |||
There was a problem hiding this comment.
Let's use interpolation rather than string concatenation and check for community name in addition to community existence:
Suggested change
| <title>Welcome - Terrastories<%= @community ? ': ' + @community.name : '' %></title> | |
| <title>Welcome - Terrastories<%= @community&.name ? ": #{@community.name}": '' %></title> |
In particular, this will ensure that if community exists but name is somehow nil, it won't crash the page.
irb> ': ' + nil
TypeError (no implicit conversion of nil into String)
irb> ": #{nil}"
=> ": "@rudokemper Do we also want to localize "Welcome" ?
There was a problem hiding this comment.
Great suggestions @lauramosher and yes - that would be a welcome 🤦 change.
There was a problem hiding this comment.
Pushed the nil safe and interpolation update, as well as localization!
lauramosher
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #948
Open to suggestions on better ways to do this. I'm fairly new to ruby.