fix(API): Catastrophic 500 when media cannot be processed #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an otherwise representable media attachment is processed for a preview or image and errors, the request fails catastrophically resulting in the Explore interface looking like it's loading forever. It was determined that this was due to the underlying processing failure and, as such, the check for `.representable?` was insufficient to catch errors. For now, we simply added a test that raises the error manually for invariable images. See https://api.rubyonrails.org/classes/ActiveStorage/Blob/Representable.html#method-i-variant Our code currently catches any ActiveStorage::Error to reduce friction points since the Explore code has guardrails in place to display other media when a preview thumbnail is unaavilable.
rudokemper
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the Explore API where when a Community Map is loaded stories are requested, the Story sidebar hangs forever. After looking into it, we noticed there was a catastrophic error on the backend from ffmpeg trying to process media that couldn't actually be processed.
Adds red spec for showing the error and code to make that spec green.
The documentation on
representation(opts).processedsuggested that checkingrepresentable?would ensure we don't attempt to process media that can't be variable or previewable. It appears that we needed additional guards when processing the preview or variant, as these can fail despite the processor accepting the blob. Since the current solution is to catch all errors originating from Active Storage, we only included one spec for one of the possible errors.