Upgrade build to Shakapacker #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-ish environments
- https on production - http on dev/offline/test
This changes the context of build from root/Rails to root. This requires specifying a -f path/to/Dockerfile when building manually: docker build -t terrastories-build -f rails/Dockerfile . or specifying the `file` argument in the builder action.
lauramosher
force-pushed
the
shakapacker
branch
from
2f315b7
to
4d2c51a
Compare
rudokemper
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our JS dependencies from webpacker to shakapacker, per upgrade guidelines to upgrade webpack versions and configuration. As such, this introduces the required configuration for shakapacker (e.g. bin/shakapacker and Procfile.dev) and removes the old configuration for webpacker.
Furthermore, this updates our Dockerfile to use bin/rake hook to bundle assets and change how we copy built assets into the public/ folder for production* consumption.