-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moment charts. #3796
Add moment charts. #3796
Conversation
Zoom performance is very poor at this point for large datasets (> 300 points). This is a known problem for victory charts. Victory docs suggests implementing domain clipping and downsampling as solutions to manage this problem. The downsampling algo given in the docs does not faithfully preserve the shape of the original full-data chart. LTTB algo looks like a better alternative. One problem still remains even after implementing LTTB. Zooming will result in the chart line fluctuating a bit because of choosing slightly different points at different zoom levels. TODOs:
|
Have improved performance by passing pre-formatted data to victory. So not implementing downsampling for now. |
Implements the following: