Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moment charts. #3796

Merged
merged 13 commits into from
Feb 14, 2020
Merged

Add moment charts. #3796

merged 13 commits into from
Feb 14, 2020

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Nov 20, 2019

Implements the following:

  • Moment lines chart
  • Moment points chart

@na9da
Copy link
Collaborator Author

na9da commented Nov 26, 2019

Zoom performance is very poor at this point for large datasets (> 300 points). This is a known problem for victory charts. Victory docs suggests implementing domain clipping and downsampling as solutions to manage this problem.

The downsampling algo given in the docs does not faithfully preserve the shape of the original full-data chart. LTTB algo looks like a better alternative.

One problem still remains even after implementing LTTB. Zooming will result in the chart line fluctuating a bit because of choosing slightly different points at different zoom levels.

TODOs:

  • Domain clipping
    - [ ] LTTB Downsampling

@na9da
Copy link
Collaborator Author

na9da commented Dec 2, 2019

Have improved performance by passing pre-formatted data to victory. So not implementing downsampling for now.

@na9da na9da merged commit e2b085f into mobx Feb 14, 2020
@rowanwins rowanwins deleted the mobx-moment-charts branch February 25, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant