WIP: UI update #7443
Draft
WIP: UI update #7443
+10,421
−694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lawrence Owen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 6 commits
January 16, 2025 16:03
ljowen
force-pushed
the
ui-update-fonts
branch
from
8fa34de to
de1282d
Compare
|
Quick UI check
Screen.Recording.2025-01-21.at.12.49.52.mov |
zoran995
reviewed
Jan 21, 2025
| return <Icon glyph={Icon.GLYPHS.closeLight} />; | ||
| } | ||
| if (this.props.viewState.isMapFullScreen) { | ||
| return <span>{btnText}</span>; |
There was a problem hiding this comment.
Do we still need this with the new UI? It will show the text in UI for a brief moment
zoran995
reviewed
Jan 21, 2025
| } | ||
| ${ | ||
| props.isCurrent && | ||
| ` | ||
| background: ${props.theme.textLight}; | ||
| color: ${props.theme.colorPrimary}; | ||
| border: 1px solid ${props.theme.greyLighter}; |
There was a problem hiding this comment.
It might be good to use some of the border/outline tricks to avoid the button getting larger/smaller due to the new border applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Major change to default theme and appearance:
May introduce breaking changes with existing maps so will be a major version.
Visual changes
Before
After
Functional changes
keepCatalogOpenTest me
Before: http://ci.terria.io/main
After: http://ci.terria.io/ui-update-fonts
Checklist
doc/.