Added Pick functionality to builders #49
Conversation
|
This looks really clean. If you are happy the data sources stuff can't be reused I'm happy to merge. |
|
I refactored it to use DataSources. What do you think @robdmoore ? Go ahead and commit if you like it, otherwise I'm happy to make any changes. |
| protected override IList<T> InitializeDataSource() | ||
| { | ||
| // This method will never be called as the list is set in the constructor. | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
Alternatively the constructor could store the list in a private field and this method could return the lost? Then you might not need the internal set on the list?
There was a problem hiding this comment.
The thing is there is already a _list field. I don't really like the idea of a second field to store the same thing.
One option is to make the field protected, in which case it becomes available to this constructor and I can just set it directly. The reason I didn't go for that though is it then becomes accessible to every class that inherits from it, something I didn't really want to do. Making the Setter internal achieves what I want, because I can set it from this class but consumers don't gain access to the private field.
I could return new List() from the InitializeDataSource method, but I thought that was misleading as it implied it might get called. This method is only called in the lazy instantiation of the list, meaning it will never be called in this implementation as we are setting the list in the constructor. If someone were to inherit from this class and call this method I'm happy it would give them an exception. They can just override it in their derived class with the behaviour they expect.
That was my thinking anyway. Let me know if you disagree at all. :-)
|
(Partly?) addresses #27 |
|
Do you mind submitting a PR to the readme to add documentation for this new feature? Also, we should bump the minor version in https://github.com/TestStack/TestStack.Dossier/blob/master/GitVersionConfig.yaml. I'll do that manually after merging this though. |
Added Pick functionality to builders
|
Yes, happy to submit a PR to document the feature. |
|
Picking documentation here: http://dossier.teststack.net/v1.0/docs/picking-list-items |
Ability to pick items from a collection during building. Uses the existing generators to either select items at random or in a repeatable sequence.