Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call base.Close() in MockFileStream.Close() #398

Merged
merged 4 commits into from
Nov 9, 2018
Merged

Call base.Close() in MockFileStream.Close() #398

merged 4 commits into from
Nov 9, 2018

Conversation

biltongza
Copy link
Contributor

Fixes #397.

robkeim
robkeim approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@robkeim robkeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me @biltongza!

@biltongza
Copy link
Contributor Author

Cool! Any chance of getting a beta with this in it? I need this to fix a failing test at work :)

@robkeim
Copy link
Contributor

robkeim commented Nov 9, 2018

@biltongza I'll defer to some of the main contributors on that @fgreinacher and @jpreese can you guys weigh in?

@fgreinacher
Copy link
Contributor

fgreinacher commented Nov 9, 2018 •
edited
Loading

LGTM, thanks for your contribution!

@fgreinacher fgreinacher merged commit 2b27e2a into TestableIO:master Nov 9, 2018
@fgreinacher
Copy link
Contributor

@biltongza Will be available at https://www.nuget.org/packages/System.IO.Abstractions.TestingHelpers/2.2.8-beta in some minutes.

@biltongza biltongza deleted the fix397 branch November 9, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robkeim robkeim robkeim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biltongza @robkeim @fgreinacher