Updated FileWrapper async calls to allow errors to bubble up. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JerrettDavis I didn't see your PR until I pushed mine #493 :( I'd prefer to avoid adding the async keyword to all of those methods because that has a performance impact. Instead we can return the underlying |
|
No worries, I was mostly trying to get a quick proof of concept working just to verify I wasn't going crazy. Whatever works! |
|
You're definitely not going crazy... thanks for taking the time to report this issue! |
|
I went ahead and corrected my PR, just in case. |
robkeim
approved these changes
Jul 9, 2019
|
Let's keep this PR, I've gone ahead and closed mine. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Await all asynchronous
FileWrappercalls. Unawaited calls did not bubble up errors, per issue #491 .